Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport 5.1 changes into master #3406

Merged
merged 5 commits into from
Oct 7, 2024
Merged

Backport 5.1 changes into master #3406

merged 5 commits into from
Oct 7, 2024

Conversation

vladvildanov
Copy link
Collaborator

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

@vladvildanov
Updated package version (#3389)
7215a52
@vladvildanov
Fix bug with Redis Set commands returns List instead of Set (#3399)
c31849c 
* Fix bug with Redis Set commands returns List instead of Set in RESP2

* Removed fixture, codestyle fixes

* Fixed tests for async

* Fixed asyncio cluster test cases

* Added Sets alignment for RESP2 and RESP3

* Updated doctests
@vladvildanov
Fix bug with partial Hiredis availability (#3400)
aa22225 
* Fix bug with partial Hiredis availability

* Added yes flag

* Codestyl fixes

* Removed redundant check

* Removed redundant checks associated with pack command

* Updated condition to check the actual flag

* Removed unused import
@vladvildanov
Fix bug with async pipeline and cluster fails with some commands (#3402)
e20f354 
* Fix bug with async pipeline fails with some commands

* Codestyl changes

* Remove keys option in cluster context
@vladvildanov
Updated package version (#3403)
4b3a6d0
dmaier-redislabs
dmaier-redislabs approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@dmaier-redislabs dmaier-redislabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The detailed review already happened as part of merging this into the just released version 5.1.

@vladvildanov vladvildanov merged commit 700045c into master Oct 7, 2024
108 checks passed
@vladvildanov vladvildanov deleted the 5.1 branch October 7, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmaier-redislabs dmaier-redislabs dmaier-redislabs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vladvildanov @dmaier-redislabs