Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix socket garbage collection #2859

Merged
merged 11 commits into from
Jul 31, 2023
Merged

Fix socket garbage collection #2859

merged 11 commits into from
Jul 31, 2023

Commits on Jul 19, 2023

  1. Redis.from_url() should have an auto-closing connection pool.

    @kristjanvalur
    kristjanvalur committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    e6a84f4 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2023

  1. An async socket now closes the write stream (synchronously) when it i… 

    …s deleted.

A StreamWriter does not reliably close its socket when it is collected.
    @kristjanvalur
    kristjanvalur committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    4efb881 View commit details
    Browse the repository at this point in the history

  2. Add tests

    @kristjanvalur
    kristjanvalur committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    2cb6651 View commit details
    Browse the repository at this point in the history

  3. Skip a test not available on all platforms.

    @kristjanvalur
    kristjanvalur committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    f32cbd7 View commit details
    Browse the repository at this point in the history

  4. changes

    @kristjanvalur
    kristjanvalur committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    6329a51 View commit details
    Browse the repository at this point in the history

  5. only test on non-cluster

    @kristjanvalur
    kristjanvalur committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    ed1b5c0 View commit details
    Browse the repository at this point in the history

  6. cope with classes that don't have _writer

    @kristjanvalur
    kristjanvalur committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    b81b77e View commit details
    Browse the repository at this point in the history

  7. don't test GC behaviour on pypy

    @kristjanvalur
    kristjanvalur committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    8fd3537 View commit details
    Browse the repository at this point in the history

  8. Allow the "auto_close_connection_pool" argument to Redis.from_url

    @kristjanvalur
    kristjanvalur committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    a80c64c View commit details
    Browse the repository at this point in the history

  9. Remove the __del__ method again from asyincio.Connection

    @kristjanvalur
    kristjanvalur committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    2d8a128 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2023

  1. Add arguments to asyncio.Redis.from_url() which are not passed to `… 

    …ConnectionPool`

Documentation specifies that the `kwargs` are pssed to `ConnectionPool` but some
arguments are not meant for it.
    @kristjanvalur
    kristjanvalur committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    34a69ff View commit details
    Browse the repository at this point in the history