Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AsyncIO Race Condition Fix #2640

Merged
merged 5 commits into from
Mar 22, 2023
Merged

AsyncIO Race Condition Fix #2640

merged 5 commits into from
Mar 22, 2023

Conversation

chayim
Copy link
Contributor

@chayim chayim commented Mar 22, 2023

closes #2624
closes #2579

@chayim chayim requested review from leibale and dvora-h March 22, 2023 14:24
@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2023

Codecov Report

Patch coverage: 79.48% and project coverage change: -0.31 ⚠️

Comparison is base (8592cac) 92.27% compared to head (ad76776) 91.96%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##              4.4    #2640      +/-   ##
==========================================
- Coverage   92.27%   91.96%   -0.31%     
==========================================
  Files         115      115              
  Lines       29613    29649      +36     
==========================================
- Hits        27325    27267      -58     
- Misses       2288     2382      +94     
Impacted Files Coverage Δ
setup.py 0.00% <ø> (ø)
redis/asyncio/client.py 92.04% <50.00%> (-0.47%) ⬇️
redis/asyncio/cluster.py 91.42% <66.66%> (-0.59%) ⬇️
tests/test_asyncio/test_cluster.py 97.06% <84.61%> (-0.55%) ⬇️
tests/test_asyncio/test_connection.py 96.11% <87.50%> (-1.59%) ⬇️

... and 20 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@chayim chayim added the bug Bug label Mar 22, 2023
@chayim chayim merged commit b3c89ac into redis:4.4 Mar 22, 2023
@chayim chayim deleted the 442-asyncio branch March 22, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants