Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clears commandTimeout timer as each respective command gets fulfilled #1336

Merged
merged 9 commits into from
Apr 24, 2021
Merged

clears commandTimeout timer as each respective command gets fulfilled #1336

merged 9 commits into from
Apr 24, 2021

Commits on Apr 14, 2021

  1. making commandTimeout clean successful timers and work in cluster mode

    @JosePedroDiasSky
    JosePedroDiasSky committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    c3f432c View commit details
    Browse the repository at this point in the history

  2. deleting timer attribution solves an issue with transactions; cluster… 

    … command doesn't need any special behaviour after all
    @JosePedroDiasSky
    JosePedroDiasSky committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    626a981 View commit details
    Browse the repository at this point in the history

  3. adding attribute annotation to keep typescript happy.

    @JosePedroDiasSky
    JosePedroDiasSky committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    a145e57 View commit details
    Browse the repository at this point in the history

  4. thought setTimeout returned a number, apparently not

    @JosePedroDiasSky
    JosePedroDiasSky committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    688e388 View commit details
    Browse the repository at this point in the history

  5. this time I ran npm run build locally first

    @JosePedroDiasSky
    JosePedroDiasSky committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    adb0d22 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2021

  1. addressing feedback

    @JosePedroDiasSky
    JosePedroDiasSky committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    f73c33e View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2021

  1. Clear timeouts for commands in offline queue 

    When client is not ready, Redis#sendCommand() will move
commands to the offline queue, and once ready, all commands
in the offline queue will be sent with Redis#sendCommand()
again. So we should check whether the timer has been set.
    @luin
    luin committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    e7b95b7 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into sky-master

    @luin
    luin committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    7c187b5 View commit details
    Browse the repository at this point in the history

  3. Address feedbacks

    @luin
    luin committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    10612c3 View commit details
    Browse the repository at this point in the history