fix: Fix autopipeline and downgrade p-map to support Node 6. [#1216] #1224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Node 6 tests wont run due to dev deps requiring higher node version As for using real cluster - its definitely an option |
|
Ok, I'll remove it from the matrix then. |
|
Node 6 removed. |
|
As soon as tests finish I'd be able to merge |
NOTE: not connected with the code itself, just unable to launch node 15 at all
|
🎉 This PR is included in version 4.19.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in there?
[x] Fixes a severe autopipeline bug that prevented correct routing.
[x] Fixes #1216 by downgrading
p-mapto2.1.0, which is the last one that supports Node 6.[x] Changes the Travis matrix to run against all Node even version >= 6, plus the current unstable one.
Note to reviewers
The autopipeline bug was not catch from the test suite since testing for cluster goes against a mock cluster.
Shall we change this to test against a real cluster?