feat: Automatically set tls.servername option with rediss:// URLs

redis · Aug 20, 2019 · 90040f9 · 90040f9
1 parent 0d190ec
commit 90040f9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/lib/redis/index.ts b/lib/redis/index.ts
@@ -212,7 +212,7 @@ Redis.prototype.parseOptions = function() {
     }
   }
   if (isTls) {
-    defaults(this.options, {tls: true})
+    defaults(this.options, {tls: {servername: this.options.host}})
   }
   defaults(this.options, Redis.defaultOptions);
 

diff --git a/test/unit/redis.ts b/test/unit/redis.ts
@@ -81,11 +81,11 @@ describe("Redis", function() {
         });
         expect(option).to.have.property("port", 6380);
 
-        option = getOption("rediss://host")
-        expect(option).to.have.property("tls", true)
+        option = getOption("rediss://host.test");
+        expect(option.tls).to.deep.equal({servername: "host.test"});
 
-        option = getOption("rediss://example.test", { tls: { hostname: "example.test" } });
-        expect(option.tls).to.deep.equal({hostname: "example.test"})
+        option = getOption("rediss://example.test", { tls: { rejectUnauthorized: false } });
+        expect(option.tls).to.deep.equal({ rejectUnauthorized: false });
       } catch (err) {
         stub.restore();
         throw err;