Skip to content
This repository has been archived by the owner on Jun 26, 2024. It is now read-only.

Conversation

service-binding-operator-bot
Copy link
Collaborator

Changes

/kind enhancement

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs
    included if any changes are user facing
  • Tests
    included if any functionality added or changed. For bugfixes please include tests that can catch regressions
  • All acceptance test scenarios included in the PR which verifies a bugfix or a requested feature reported by a non-member are tagged with @external-feedback tag.
  • Follows the commit message standard

Signed-off-by: Andy Sadler <ansadler@redhat.com>
@service-binding-operator-bot service-binding-operator-bot added approved cherry-pick kind/enhancement New feature or request lgtm release/v1.4.x Used to mark PRs to be cherry-picked in release-v1.4.x branch labels Oct 30, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sadlerap
Copy link
Contributor

/hold

@sadlerap
Copy link
Contributor

/retest

1 similar comment
@sadlerap
Copy link
Contributor

/retest

@sadlerap
Copy link
Contributor

/unhold

@sadlerap
Copy link
Contributor

/retest

Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #1521 (b5438c3) into release-v1.4.x (755814b) will not change coverage.
Report is 4 commits behind head on release-v1.4.x.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           release-v1.4.x    #1521   +/-   ##
===============================================
  Coverage           58.16%   58.16%           
===============================================
  Files                  35       35           
  Lines                3014     3014           
===============================================
  Hits                 1753     1753           
  Misses               1093     1093           
  Partials              168      168           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 755814b...b5438c3. Read the comment docs.

@openshift-ci openshift-ci bot merged commit d4547be into redhat-developer:release-v1.4.x Nov 1, 2023
25 checks passed
@service-binding-operator-bot service-binding-operator-bot deleted the cherry-pick_release-v1.4.x_906f0acc_3e08d62b-3f00-4bad-b234-86c290ac884f branch November 1, 2023 00:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved cherry-pick kind/enhancement New feature or request lgtm release/v1.4.x Used to mark PRs to be cherry-picked in release-v1.4.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants