Skip to content
This repository has been archived by the owner on Jun 26, 2024. It is now read-only.

Conversation

service-binding-operator-bot
Copy link
Collaborator

OpenShift 4.14+ deprecates support for deploymentconfig resources, so we shouldn't run tests that depend on them in those environments.

Changes

/kind bug

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs
    included if any changes are user facing
  • Tests
    included if any functionality added or changed. For bugfixes please include tests that can catch regressions
  • All acceptance test scenarios included in the PR which verifies a bugfix or a requested feature reported by a non-member are tagged with @external-feedback tag.
  • Follows the commit message standard

…1470)

OpenShift 4.14+ deprecates support for deploymentconfig resources, so we shouldn't run tests that
depend on them in those environments.

Signed-off-by: Andy Sadler <ansadler@redhat.com>
@service-binding-operator-bot service-binding-operator-bot added approved cherry-pick kind/bug Something isn't working lgtm release/v1.3.x Used to mark PRs to be cherry-picked in release-v1.3.x branch labels Aug 16, 2023
@openshift-ci openshift-ci bot requested review from pmacik and sadlerap August 16, 2023 22:10
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sadlerap
Copy link
Contributor

/retest

@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #1473 (c3d8835) into release-v1.3.x (dce78e3) will not change coverage.
Report is 1 commits behind head on release-v1.3.x.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           release-v1.3.x    #1473   +/-   ##
===============================================
  Coverage           57.99%   57.99%           
===============================================
  Files                  33       33           
  Lines                2816     2816           
===============================================
  Hits                 1633     1633           
  Misses               1026     1026           
  Partials              157      157           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dce78e3...c3d8835. Read the comment docs.

@openshift-merge-robot openshift-merge-robot merged commit c99c3a9 into redhat-developer:release-v1.3.x Aug 17, 2023
17 checks passed
@service-binding-operator-bot service-binding-operator-bot deleted the cherry-pick_release-v1.3.x_899947fb_3ddee69d-d5fd-41f7-a9e7-f4c1261ccb3e branch August 17, 2023 05:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved cherry-pick kind/bug Something isn't working lgtm release/v1.3.x Used to mark PRs to be cherry-picked in release-v1.3.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants