Skip to content
This repository has been archived by the owner on Jun 26, 2024. It is now read-only.

Add polling to App.get_generation in tests #1466

Merged

Conversation

filariow
Copy link
Contributor

@filariow filariow commented Aug 8, 2023

Changes

Make tests more robust adding a polling on App.get_generation

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs
    included if any changes are user facing
  • Tests
    included if any functionality added or changed. For bugfixes please include tests that can catch regressions
  • All acceptance test scenarios included in the PR which verifies a bugfix or a requested feature reported by a non-member are tagged with @external-feedback tag.
  • Follows the commit message standard

Signed-off-by: Francesco Ilario <filario@redhat.com>
@filariow filariow requested review from sadlerap and removed request for baijum and dperaza4dustbit August 8, 2023 16:53
Copy link
Contributor

@sadlerap sadlerap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sadlerap

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Aug 8, 2023
@filariow
Copy link
Contributor Author

filariow commented Aug 9, 2023

/retest

@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #1466 (f391fdf) into master (ecde2a4) will not change coverage.
Report is 3 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1466   +/-   ##
=======================================
  Coverage   58.16%   58.16%           
=======================================
  Files          35       35           
  Lines        3014     3014           
=======================================
  Hits         1753     1753           
  Misses       1093     1093           
  Partials      168      168           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecde2a4...f391fdf. Read the comment docs.

@openshift-merge-robot openshift-merge-robot merged commit d66fbd4 into redhat-developer:master Aug 9, 2023
19 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants