Decouple examples from service #129
Conversation
masayag
force-pushed
the
decouple-workflow-example
branch
2 times, most recently
from
4fa786c
to
be95404
Compare
masayag
force-pushed
the
decouple-workflow-example
branch
from
be95404
to
0b52924
Compare
|
@masayag we fail with building the image. Please take a look
|
masayag
force-pushed
the
decouple-workflow-example
branch
from
0b52924
to
2b5ee9e
Compare
masayag
force-pushed
the
decouple-workflow-example
branch
2 times, most recently
from
81d1049
to
f286a18
Compare
masayag
force-pushed
the
decouple-workflow-example
branch
6 times, most recently
from
bb790e7
to
ae7d933
Compare
The purpose of this PR is to decouple the user's workflows from being built into the workflow-service by using the PropertiesLauncher as the Start-Class of the application. Extra dependencies can be provided via system property `loader.path`. In addition, to satisfy all runtime dependencies, the workflow-example is being built with a plugin to include all of its dependencies in a single jar. For local development, a local profile was added to include the workflow-examples dependency in the service's path: ``` mvn clean install -Plocal ``` Signed-off-by: Moti Asayag <masayag@redhat.com>
masayag
force-pushed
the
decouple-workflow-example
branch
from
ae7d933
to
3e3679c
Compare
| @@ -1 +1,3 @@ | |||
| java -jar -Dspring.profiles.active=local target/workflow-service-1.0.3-SNAPSHOT.jar | |||
| java -jar -Dspring.profiles.active=local \ | |||
There was a problem hiding this comment.
TBH, this is already part of the makefile :-)
There was a problem hiding this comment.
Do you suggest deleting this script? It also repeats itself under workflow-examples.
And if we maintain that script, it should probably be parameterized with the version instead hard-coding it
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eloycoto, masayag, RichardW98 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The purpose of this PR is to decouple the user's workflows from being built into the workflow-service by using the PropertiesLauncher as the Start-Class of the application.
Extra dependencies can be provided via env-var
loader.path. In addition, to satisfy all runtime dependencies, the workflow-example is being built with a plugin to include all of its dependencies in a single jar.For local development, a local profile was added to include the
workflow-examples dependency in the service's path: