Skip to content
This repository has been archived by the owner on Aug 26, 2022. It is now read-only.

Limit the number of local shell sessions to 1 #565

Merged
merged 1 commit into from
Jan 11, 2022
Merged

Limit the number of local shell sessions to 1 #565

merged 1 commit into from
Jan 11, 2022

Conversation

jc-rh
Copy link
Contributor

@jc-rh jc-rh commented Jan 7, 2022

No description provided.

javierpena
javierpena reviewed Jan 10, 2022
View reviewed changes
Copy link
Contributor

@javierpena javierpena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me so far. I'm trying to find out why some operator tests were skipped, it looks like some corner case in the cnf-certification-test-partner repo.

@javierpena
Copy link
Contributor

I've finally managed to work around the operator skipped tests with redhat-best-practices-for-k8s/certsuite-sample-workload#76 . There's also an issue with minikube (kubernetes/minikube#11608), but it does not seem to happen when using the docker driver.

@jc-rh jc-rh merged commit e798c34 into redhat-best-practices-for-k8s:main Jan 11, 2022
@greyerof greyerof mentioned this pull request Feb 8, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sebrandon1 sebrandon1 sebrandon1 approved these changes

@javierpena javierpena javierpena approved these changes

@hamadise hamadise Awaiting requested review from hamadise

@edcdavid edcdavid Awaiting requested review from edcdavid

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jc-rh @javierpena @sebrandon1 @hamadise