Failed to reset value in retained_map on erase #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kleunen
force-pushed
the
retained_topic_map_fail
branch
from
36324f0
to
ed75d8c
Compare
Codecov Report
@@ Coverage Diff @@
## retained_topic_map_fail #694 +/- ##
============================================================
+ Coverage 69.51% 82.07% +12.55%
============================================================
Files 43 47 +4
Lines 5482 7100 +1618
============================================================
+ Hits 3811 5827 +2016
+ Misses 1671 1273 -398 |
redboltz
reviewed
Oct 18, 2020
redboltz
reviewed
Oct 18, 2020
kleunen
force-pushed
the
retained_topic_map_fail
branch
2 times, most recently
from
0aa3521
to
ae45fcf
Compare
|
There is still an issue in this PR, so don't merge yet |
kleunen
force-pushed
the
retained_topic_map_fail
branch
from
ae45fcf
to
e7cfa17
Compare
|
Now should work OK |
|
LGTM, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.