Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 76 test saves #236

Merged
merged 9 commits into from
Dec 10, 2022
Merged

Issue 76 test saves #236

merged 9 commits into from
Dec 10, 2022

Conversation

mfloto
Copy link
Contributor

@mfloto mfloto commented Dec 7, 2022

  • test saves for three different states of the game
  • stored in separated folder (test-saves)

@Flippchen
Copy link
Member

Wir sollten vllt doch warten bis das Spiel sich nicht ändert, da ja auch die Test Maschine drinne ist und die ja noch weg kommt etc

@mfloto mfloto marked this pull request as draft December 8, 2022 00:21
Nereuxofficial
Nereuxofficial approved these changes Dec 9, 2022
View reviewed changes
Copy link
Contributor

@Nereuxofficial Nereuxofficial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wir bräuchten noch ne Methode um die (möglichst) vollautomatisiert nacheinander zu laden, die kann aber auch ich machen

@mfloto mfloto marked this pull request as ready for review December 10, 2022 15:52
Flippchen
Flippchen approved these changes Dec 10, 2022
View reviewed changes
Copy link
Member

@Flippchen Flippchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Segelente
Segelente approved these changes Dec 10, 2022
View reviewed changes
Copy link
Member

@Segelente Segelente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Flippchen Flippchen merged commit 6ca798f into dev Dec 10, 2022
@Flippchen Flippchen deleted the issue-76-test-saves branch December 10, 2022 17:07
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nereuxofficial Nereuxofficial Nereuxofficial approved these changes

@Segelente Segelente Segelente approved these changes

@Flippchen Flippchen Flippchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mfloto @Flippchen @Nereuxofficial @Segelente