fix: adding logic to apply trustyai prometheus #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this will need backport to ODH |
zdtsw
force-pushed
the
trusty_GA
branch
2 times, most recently
from
264744d
to
11ce64e
Compare
ruivieira
approved these changes
Jan 24, 2024
|
and when i killed trusty pod i got
|
|
we will need red-hat-data-services/trustyai-service-operator#13 to go together
|
Signed-off-by: Wen Zhou <wenzhou@redhat.com>
Signed-off-by: Wen Zhou <wenzhou@redhat.com>
record rules Signed-off-by: Wen Zhou <wenzhou@redhat.com>
|
to sum the last test result here:
|
|
Merge this into 2.6 first, if we have more problem on this topic, can fix before backport to main |
3 tasks
zdtsw
added a commit
to zdtsw-forking/rhods-operator
that referenced
this pull request
Feb 8, 2024
…#173) * update(trustyai): adding logic to monitoring Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix(trustyai): prometheus rules for probe Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update(trusty): prometheus to use job instead of instance name for record rules Signed-off-by: Wen Zhou <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com>
zdtsw
added a commit
to zdtsw-forking/rhods-operator
that referenced
this pull request
Feb 8, 2024
…#173) * update(trustyai): adding logic to monitoring Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix(trustyai): prometheus rules for probe Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update(trusty): prometheus to use job instead of instance name for record rules Signed-off-by: Wen Zhou <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com>
VaishnaviHire
added a commit
that referenced
this pull request
Feb 9, 2024
[backport]: from 2.6 to 2.7 (#173)
VaishnaviHire
added a commit
that referenced
this pull request
Feb 9, 2024
[backport] from 2.6 to main (#173)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as part of https://issues.redhat.com/browse/RHOAIENG-99
we have rules defined in commit #161
but still need the logic in operator to apply such
also tuning these rules from original commit
new: (live build quay.io/wenzhou/rhods-operator-catalog:v2.6.173)
update tests:
old:
test on live build: can confirm config has been applied for trustyai