Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CodeQuality] Remove no returns check on ResponseReturnTypeControllerActionRector #652

Merged
merged 1 commit into from
Jul 30, 2024
Merged

[CodeQuality] Remove no returns check on ResponseReturnTypeControllerActionRector #652

merged 1 commit into from
Jul 30, 2024

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Jul 30, 2024 •
edited
Loading

Ref #651 (review)

the check already verified in above check:

if (! $this->returnAnalyzer->hasOnlyReturnWithExpr($classMethod, $returns))

The fixture for it already exists at

rector-symfony/rules-tests/CodeQuality/Rector/ClassMethod/ResponseReturnTypeControllerActionRector/Fixture/skip_no_return.php.inc

Lines 10 to 13 in fcaedb3

#[Route]
public function detail()
{
}

@samsonasik samsonasik mentioned this pull request Jul 30, 2024
Merged
@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit 4ff7e43 into main Jul 30, 2024
5 checks passed
@samsonasik samsonasik deleted the remove-no-returns-check branch July 30, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@samsonasik