Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not convert to array Process->setInput() #647

Merged
merged 1 commit into from
Aug 18, 2024

Conversation

refsz
Copy link
Contributor

@refsz refsz commented Jul 13, 2024

Corrects the problem introduced #646

Closes #646

@samsonasik
Copy link
Member

samsonasik commented Jul 13, 2024

I think definition should be the other way around, instead of define the excluded method, define the will be processed method instead, so new method will not automatically transformed

@samsonasik
Copy link
Member

samsonasik commented Aug 18, 2024

I verified that pass array on setInput() will got error:

 "Symfony\Component\Process\Process::setInput" only accepts strings, Traversable objects or stream resources. 

@samsonasik samsonasik enabled auto-merge (squash) August 18, 2024 07:43
@samsonasik
Copy link
Member

Thank you @refsz

@samsonasik samsonasik merged commit 0eca1e4 into rectorphp:main Aug 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StringToArrayArgumentProcessRector with $process->setInput()
2 participants