[TypeDeclaration] Skip void on BoolReturnTypeFromBooleanStrictReturnsRector

[samsonasik]

Fixes rectorphp/rector#8717
Ref https://getrector.com/demo/299253f8-253d-4782-955c-7f2444906bc7

[samsonasik]

Fixed 🎉 /cc @OA

[samsonasik]

I moved possible void check into BetterNodeFinder::findReturnsScoped()

[samsonasik]

Moving check into BetterNodeFinder seems cause cycling dependency, due to SilentVoidResolver require BetterNodeFinder so cause flip flop...

[samsonasik]

The solution for now is verify :

if (! $this->returnAnalyzer->hasOnlyReturnWithExpr($functionLike)) {
    return null;
}

into each type declaration rules, since has a way to verify possible void

[samsonasik]

All checks have passed 🎉 @TomasVotruba I am merging it to have faster feedback to test ;)

[TomasVotruba]

Thanks 👍

[OA]

looks good on our side!