Skip files with short <?= PHP tag as leads to invalid changes

[TomasVotruba]

Currently, PHP allows to use <?= tags intead of typical <?php ...: https://www.php.net/manual/en/language.basic-syntax.phptags.php

Yet, such tags would lead to breaking changes like:

+<?php
+
+declare(strict_types=1);
 <?= $something ?>

We currently skip this on importing files, but we should not process such files at all, to avoid breaking code.

Use php-cs-fixer rule https://cs.symfony.com/doc/rules/php_tag/echo_tag_syntax.html to migrate your short tags. Then use Rector safely 👍

[TomasVotruba]

Checking <?= in /vendor, there are only dev packages with string match:

[TomasVotruba]

Seem broken symlinks does not allow content filter on Finder on Windows:

I don't see any option than to other skip this test on Windows, as bug in symfony/finder.

If someone is using Windows, a fix would be great :)

[TomasVotruba]

Let's see how downgrade goes ...

Edit: all good ✔️
rectorphp/rector@bcb11a7

[samsonasik]

@staabm @paulbalandan are using windows iirc, could you give some insight? Thank you.

[samsonasik]

The release note should include the recommendation for migrating to long php tag,

Also probably better, add warning that list of files will not be processed, so user can know that the code should be migrated to long php tag first when running it ...

[TomasVotruba]

Also probably better, add warning that list of files will not be processed, so user can know that the code should be migrated to long php tag first when running it ...

That would be helpful indeed. Could you add this?

[samsonasik]

I will try

[samsonasik]

Windows filter files symlink fixed at PR:

• [Windows] Fix windows filter files with <?= start content on FilesFinder #6072

[staabm]

What exactly needs to be tested/fixed in windows?

[samsonasik]

@staabm on windows already fixed at PR:

• [Windows] Fix windows filter files with <?= start content on FilesFinder #6072

[samsonasik]

I created PR to report files start with <?=

• [DX] Report files with start with <?= short php tag #6075