Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TypeDeclaration] Add AddClosureReturnTypeFromStrictNativeCallRector #6059

Merged
merged 1 commit into from
Jun 28, 2024
Merged

[TypeDeclaration] Add AddClosureReturnTypeFromStrictNativeCallRector #6059

merged 1 commit into from
Jun 28, 2024

Conversation

samsonasik
Copy link
Member

Part of resolve this issue effort:

Ref from PR comment:

this PR extract Closure from ReturnTypeFromStrictNativeCallRector into separate new rule: AddClosureReturnTypeFromStrictNativeCallRector special for Closure only.

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@TomasVotruba
Copy link
Member

Rebase is needed

@samsonasik
Copy link
Member Author

Rebased 👍

@TomasVotruba
Copy link
Member

Thank you 👍

@TomasVotruba TomasVotruba merged commit 0796b92 into main Jun 28, 2024
33 checks passed
@TomasVotruba TomasVotruba deleted the native-return-closure branch June 28, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samsonasik @TomasVotruba