[DX] Inform about deprecated rules in config #6047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
changed the title
samsonasik
reviewed
Jun 26, 2024
TomasVotruba
force-pushed
the
tv-report-deprecated-rules
branch
5 times, most recently
from
7721e10
to
235d832
Compare
… and deprecations
…d will be removed
TomasVotruba
force-pushed
the
tv-report-deprecated-rules
branch
from
235d832
to
8edd0c6
Compare
samsonasik
reviewed
Jun 26, 2024
rules/CodingStyle/Rector/Foreach_/MultiDimensionalArrayToArrayDestructRector.php
Outdated
Show resolved
Hide resolved
TomasVotruba
force-pushed
the
tv-report-deprecated-rules
branch
from
8edd0c6
to
4529908
Compare
samsonasik
reviewed
Jun 26, 2024
| RECTOR_DISABLE_PARALLEL: ${{ matrix.rector_disable_parallel }} | ||
|
|
||
| # run e2e test with dry run once more, we expect non-zero exit code again | ||
| - run: php ../e2eTestChangingRunnerWithCache.php -o expected-output-2-dry-run.diff --dry-run |
There was a problem hiding this comment.
e2e/e2eTestChangingRunnerWithCache.php can be removed since no longer used.
|
@TomasVotruba will this PR remove warnings for PostRector updates? I use it with NameImportingPostRector: use Rector\Config\RectorConfig;
return RectorConfig::configure()
->withSkip([
NameImportingPostRector::class => [
__DIR__.'/bootstrap/providers.php',
__DIR__.'/config',
],
])
|
|
@sanfair Good point, I'll add exception for post rules. Thanks 👍 |
This was referenced Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's group reports together in the end, so they're noticed and can be resolved one by one: