Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bc Break] [Alternative] Drop children class detection #5995

Merged
merged 4 commits into from
Jun 21, 2024

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Jun 21, 2024

Children class detection is usefull, but collect class may cause side effect on performance, so this PR drop it, with caveat for add return type which may cause bug when class has child.

For win-win solution, I skip add return type on abstract class.

FYI: @dorrogeray @staabm @chescos @X-Coder264 @mfn

Trade-off: back to original functionality, that cannot detect child, but set skip on add return type on abstract class which mostly overridden.

Notes:

For limit on final class, that probably needs separate PR for separate discussion, as they will need to check on param type addition rules as well.

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba you decide ;)

@samsonasik
Copy link
Member Author

Also @nuryagdym FYI

@TomasVotruba
Copy link
Member

Thank you for fast work 👏 Let's roll

@chescos
Copy link

chescos commented Jun 21, 2024

Thanks! My runtime is back down from 16 minutes to 2 minutes after upgrading from v1.1.0 to v1.1.1.

@TomasVotruba
Copy link
Member

@chescos Awesome, glad to hear that 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants