Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wikidata fix and unit tests #932

Merged
merged 7 commits into from
Sep 17, 2019
Merged

Wikidata fix and unit tests #932

merged 7 commits into from
Sep 17, 2019

Conversation

miguelgfierro
Copy link
Collaborator

@miguelgfierro miguelgfierro commented Sep 16, 2019 •
edited
Loading

Description

Related Issues

#919
#880

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.

loomlike
loomlike reviewed Sep 16, 2019
View reviewed changes
Copy link
Collaborator

@loomlike loomlike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix! Left some minor comments.

tests/unit/test_wikidata.py Show resolved Hide resolved
tests/unit/test_wikidata.py Show resolved Hide resolved
notebooks/01_prepare_data/wikidata_knowledge_graph.ipynb Outdated Show resolved Hide resolved
reco_utils/dataset/wikidata.py Show resolved Hide resolved
gramhagen
gramhagen approved these changes Sep 16, 2019
View reviewed changes
Copy link
Collaborator

@gramhagen gramhagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me

@miguelgfierro miguelgfierro merged commit eb933bb into staging Sep 17, 2019
@miguelgfierro miguelgfierro deleted the miguel/wikidata_fix branch September 17, 2019 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loomlike loomlike loomlike left review comments

@gramhagen gramhagen gramhagen approved these changes

@almudenasanz almudenasanz Awaiting requested review from almudenasanz

@yueguoguo yueguoguo Awaiting requested review from yueguoguo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miguelgfierro @gramhagen @loomlike