Add nightly_gpu badge to build status page, update unit_tests, add nightly_cpu #839
Conversation
bethz
requested review from
gramhagen,
miguelgfierro and
yueguoguo
as code owners
There was a problem hiding this comment.
I think it will be better to just replace all the linux badges with badges generated through the Azureml devops pipeline once their ready. Also I don't think we need to differentiate them as AzureML at that point, though we should find a good way to highlight that capability.
Can you back-out the readme changes for now?
|
When Miguel and I discussed the release of the pipelines, he had suggested starting to add the badges. |
README.md
Outdated
| @@ -92,6 +92,9 @@ This project welcomes contributions and suggestions. Before contributing, please | |||
| | **Windows CPU** | master | [](https://msdata.visualstudio.com/AlgorithmsAndDataScience/_build/latest?definitionId=6743) | | staging | [](https://msdata.visualstudio.com/AlgorithmsAndDataScience/_build/latest?definitionId=6752) | | |||
| | **Windows GPU** | master | [](https://msdata.visualstudio.com/AlgorithmsAndDataScience/_build/latest?definitionId=6756) | | staging | [](https://msdata.visualstudio.com/AlgorithmsAndDataScience/_build/latest?definitionId=6761) | | |||
| | **Windows Spark** | master | [](https://msdata.visualstudio.com/AlgorithmsAndDataScience/_build/latest?definitionId=6757) | | staging | [](https://msdata.visualstudio.com/AlgorithmsAndDataScience/_build/latest?definitionId=6754) | | |||
| | **AzureML GPU** | master | [](https://dev.azure.com/best-practices/recommenders/_build/latest?definitionId=5&branchName=master)] | | staging | [](https://dev.azure.com/best-practices/recommenders/_build/latest?definitionId=5&branchName=staging)] | |||
There was a problem hiding this comment.
Sorry maybe I didn't explain myself correctly. I wasn't referring to these badges, as Scott mentioned, when the new tests are in place, we could update them with the new version from DevOps.
What I was saying is that it would be nice to have the azureml unit tests side by side with the Linux tests, in a similar way that now the windows tests appear side by side when someone does a PR.
For the nightly builds, we can just have them in the background running for some time, and when we make sure they run correctly, we can switch
There was a problem hiding this comment.
ok, wfm. I removed the badge from the README.md.
Add nightly_gpu badge to build status page, update unit_tests, add nightly_cpu
Description
Add AzureML badge for nightly_gpu in build status table in README.md (last line).
Update cpu_unit_tests to rename branch to something generic, update compute.
Add nightly_cpu yml for nightly tests.
Related Issues
This is new work.
Checklist: