Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python evaluation improvement #713

Merged
merged 10 commits into from
Apr 9, 2019
Merged

python evaluation improvement #713

merged 10 commits into from
Apr 9, 2019

Conversation

gramhagen
Copy link
Collaborator

Description

cleanup to python evaluation - ranking section
moved decorators to merging methods in preparation of creating new dataframe caching decorator

Related Issues

Checklist:

  • My code follows the code style of this project, as detailed in our contribution guidelines.
  • I have added tests.
  • I have updated the documentation accordingly.

@gramhagen gramhagen mentioned this pull request Apr 5, 2019
Closed
3 tasks
@gramhagen
Copy link
Collaborator Author

I added a lru cache decorator for pandas dataframes, check it out in pandas_df_utils @miguelgfierro @msalvaris

@gramhagen gramhagen mentioned this pull request Apr 9, 2019
Closed
miguelgfierro
miguelgfierro approved these changes Apr 9, 2019
View reviewed changes
Copy link
Collaborator

@miguelgfierro miguelgfierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing job!

@miguelgfierro miguelgfierro merged commit 1e60d5b into staging Apr 9, 2019
@miguelgfierro miguelgfierro deleted the gramhagen/python_evaluation_improvement branch April 9, 2019 14:15
@gramhagen gramhagen mentioned this pull request Apr 10, 2019
Closed
yueguoguo pushed a commit that referenced this pull request Sep 9, 2019
@miguelgfierro
Merge pull request #713 from Microsoft/gramhagen/python_evaluation_im…
2d56459 
…provement

python evaluation improvement
@anargyri anargyri mentioned this pull request Sep 13, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msalvaris msalvaris msalvaris left review comments

@miguelgfierro miguelgfierro miguelgfierro approved these changes

@yueguoguo yueguoguo Awaiting requested review from yueguoguo

@anargyri anargyri Awaiting requested review from anargyri anargyri is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gramhagen @miguelgfierro @msalvaris