-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Staging to main: AzureML migration to v2 #2137
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>
Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>
Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
Review test readme and define best practices
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
Added free course on Recommendation systems
* Migrate AML SDK from v1 to v2 Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Correct MLClient constructor paramenter names Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Remove unsupported operation begin_start() on AmlCompute Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Add label for environments.get() Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Remove environment get Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Update Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Correct experiment and environment names Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Correct compute Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Create Conda env inside Dockerfile Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Catch ResourceNotFoundError Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Correct experiment name Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Update env creation and job running Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Try waiting for completion by stream Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Try to fix conda activate Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Import sys Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Change logging level Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Exit directly once pytest fails Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Set numpy<2.0.0 due to issue of cornac Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Correct Dockerfile Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Change heredoc Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Set dockerfile version Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Copy environment.yml to container Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Update .github/actions/azureml-test/action.yml Co-authored-by: Miguel Fierro <3491412+miguelgfierro@users.noreply.github.com> * Update as suggested by Andreas * Print pytest logs Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Group outputs Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Install pip in conda env, and show pytest warnings Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Add command name Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Update Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Show warnings in pytest Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Show warnings in pytest Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> --------- Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> Co-authored-by: Miguel Fierro <3491412+miguelgfierro@users.noreply.github.com>
miguelgfierro
requested review from
gramhagen,
anargyri,
loomlike,
wutaomsft and
SimonYansenZhao
as code owners
July 31, 2024 06:20
SimonYansenZhao
approved these changes
Jul 31, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jul 31, 2024
Staging to main: AzureML migration to v2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding the latest changes in AzureML.
Related Issues
There is still this issue unfixed #2133 which is breaking the tests (both stating and main). However, it is not a problem with the code itself, it is just that the dataset URL is broken.
References
Checklist:
git commit -s -m "your commit message"
.staging branch
AND NOT TOmain branch
.