Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug when reading dataset with timestamp for sasrec model #2052

Merged
merged 9 commits into from
Feb 7, 2024

Conversation

gazon1
Copy link
Contributor

@gazon1 gazon1 commented Jan 5, 2024

Description

When reading dataset with timestamp sasrec model would never use timestamp and it would crash with an error when splitting dataset with timestamp

Related Issues

References

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

miguelgfierro and others added 6 commits August 31, 2023 21:18
Staging to main: Remove support for Python 3.7 and redefinition of tests
Staging to main: LF announcement and GRU update
Staging to main: security fix due to Tensorflow
Staging to main: Fix bug in MAP and added new notebook programmatic execution
Fixed bug with reading dataset with splitting dataset with timestamp
added exception for unkown count of columns
fixed typo
@gazon1 gazon1 changed the title Fixed bug with reading dataset with splitting dataset with timestamp Fixed bug when reading dataset with timestamp for sasrec model Jan 5, 2024
@miguelgfierro
Copy link
Collaborator

Hi @gazon1, would you mind changing the PR to staging, and signing the commit?

@miguelgfierro miguelgfierro changed the base branch from main to staging February 7, 2024 16:42
Copy link
Collaborator

@miguelgfierro miguelgfierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@miguelgfierro miguelgfierro mentioned this pull request Feb 7, 2024
5 tasks
@miguelgfierro
Copy link
Collaborator

All the test pass: #2060 merging this PR

@miguelgfierro miguelgfierro merged commit 2c22f5e into recommenders-team:staging Feb 7, 2024
1 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants