Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test failure/success in AzureML tests #1885

Merged
merged 1 commit into from
Feb 21, 2023
Merged

Fix test failure/success in AzureML tests #1885

merged 1 commit into from
Feb 21, 2023

Conversation

pradnyeshjoshi
Copy link
Collaborator

@pradnyeshjoshi pradnyeshjoshi commented Feb 21, 2023 •
edited
Loading

Description

Fixed test fail/success in AzureML tests. This PR was tested by manually triggering a unit test run: https://github.com/microsoft/recommenders/actions/runs/4228508655, which is expected to fail.

Related Issues

#1884

References

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

@pradnyeshjoshi pradnyeshjoshi self-assigned this Feb 21, 2023
@pradnyeshjoshi pradnyeshjoshi mentioned this pull request Feb 21, 2023
Closed
miguelgfierro
miguelgfierro approved these changes Feb 21, 2023
View reviewed changes
Copy link
Collaborator

@miguelgfierro miguelgfierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@miguelgfierro miguelgfierro merged commit d993fd3 into staging Feb 21, 2023
@miguelgfierro miguelgfierro deleted the pradjoshi/test_status branch February 21, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelgfierro miguelgfierro miguelgfierro approved these changes

@gramhagen gramhagen Awaiting requested review from gramhagen gramhagen is a code owner

@anargyri anargyri Awaiting requested review from anargyri anargyri is a code owner

@loomlike loomlike Awaiting requested review from loomlike loomlike is a code owner

@wutaomsft wutaomsft Awaiting requested review from wutaomsft wutaomsft is a code owner

@simonzhaoms simonzhaoms Awaiting requested review from simonzhaoms

Assignees

@pradnyeshjoshi pradnyeshjoshi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pradnyeshjoshi @miguelgfierro