Implemented Spark item to item recommenders #1809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
August 7, 2022 18:36
ChuyangKe
requested review from
miguelgfierro,
gramhagen,
anargyri,
loomlike and
wutaomsft
as code owners
| @@ -488,3 +524,72 @@ def recommend_k_items( | |||
| ) | |||
| else: | |||
| raise ValueError("No cache_path specified") | |||
|
|
|||
| def get_topk_most_similar_users(self, test, user, top_k=10): | |||
There was a problem hiding this comment.
One question, have you checked that the results between the CPU version and this one are the same?
There was a problem hiding this comment.
Yes, we are using the same test cases as for the CPU version.
Comment on lines
+191
to
+195
| # compute item frequencies | ||
| self.item_frequencies = item_cooccurrence.filter( | ||
| F.col("i1") == F.col("i2") | ||
| ).select(F.col("i1").alias("item_id"), F.col("value").alias("frequency")) | ||
|
|
There was a problem hiding this comment.
question to @simonzhaoms will the item-item function have any relationship with the work you are doing about the new similarities?
| if not items: | ||
| raise ValueError("Not implemented") | ||
|
|
||
| return self.item_frequencies.orderBy("frequency", ascending=False).limit(top_k) |
There was a problem hiding this comment.
I noticed that the sarplus tests are triggered, but there is a badge in the main page that is failing: https://github.com/microsoft/recommenders/tree/staging/contrib/sarplus @simonzhaoms do you know what is the problem?
miguelgfierro
approved these changes
Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implemented get_topk_most_similar_users() and get_popularity_based_topk() for SAR+.
Related Issues
Checklist:
staging branchand not tomain branch.