-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added time performance tests #1765
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, some comments
# The thresholds are calculated by MEAN + 5 * STANDARD DEVIATION. | ||
|
||
|
||
def test_merge_rating(rating_true, rating_pred): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pradnyeshjoshi Chuyang needs to add these tests to some of the test groups. I'm thinking that we might want to create a small tutorial to help developers add tests. What do you think?
…removed unused lines, updated benchmark results
…nto chuyang/time_test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
really good
tests/unit/recommenders/evaluation/test_python_evaluation_time_performance.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great work Chuyang
Description
Added time performance tests for rating and ranking metrics.
The time baselines are provided to ensure that the metrics can be computed in a reasonable amount of time on the same testing server. Currently the thresholds are set as MEAN + 5 * STANDARD DEVIATION based on benchmark results.
List of testing functions:
Related Issues
Related to issue #1750
Checklist:
staging branch
and not tomain branch
.