Implement time_now for sarplus #1719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonzhaoms
requested review from
miguelgfierro,
gramhagen,
anargyri,
loomlike and
wutaomsft
as code owners
Codecov Report
@@ Coverage Diff @@
## staging #1719 +/- ##
============================================
+ Coverage 0.00% 23.20% +23.20%
============================================
Files 87 88 +1
Lines 9132 9142 +10
============================================
+ Hits 0 2121 +2121
- Misses 0 7021 +7021
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Comment on lines
+122
to
+131
| query = self._format(""" | ||
| SELECT {col_user}, | ||
| {col_item}, | ||
| SUM( | ||
| {col_rating} * | ||
| POW(2, (CAST({col_timestamp} AS LONG) - {time_now}) / {time_decay_half_life}) | ||
| ) AS {col_rating} | ||
| FROM {prefix}df_train_input | ||
| GROUP BY {col_user}, {col_item} | ||
| CLUSTER BY {col_user} |
There was a problem hiding this comment.
I noticed there is a change and we don't have the exponential anymore. If you get the same data in SAR and SAR+ with the time decay, do you get the same result?
There was a problem hiding this comment.
You are right. Tests to verify are needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
time_nowin SAR+ is not implemented. This PR provides the implementation fortime_now.TODO:
time_nowtime_nowRelated Issues
Checklist:
staging branchand not tomain branch.