Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct supported python version #1711

Merged
merged 1 commit into from
May 3, 2022

Conversation

simonzhaoms
Copy link
Collaborator

Description

The supported Python version in README is incorrect.

Related Issues

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

@codecov-commenter
Copy link

Codecov Report

Merging #1711 (6aa4e8d) into staging (59fdcd2) will increase coverage by 23.41%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           staging    #1711       +/-   ##
============================================
+ Coverage     0.00%   23.41%   +23.41%     
============================================
  Files           88       88               
  Lines         9142     9142               
============================================
+ Hits             0     2141     +2141     
- Misses           0     7001     +7001     
Flag Coverage Δ
nightly ?
pr-gate 23.41% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
recommenders/datasets/mind.py 0.00% <0.00%> (ø)
recommenders/datasets/movielens.py 66.37% <0.00%> (+66.37%) ⬆️
recommenders/datasets/download_utils.py 90.00% <0.00%> (+90.00%) ⬆️
recommenders/evaluation/spark_evaluation.py 87.11% <0.00%> (+87.11%) ⬆️
recommenders/models/newsrec/io/mind_iterator.py 0.00% <0.00%> (ø)
recommenders/models/newsrec/models/base_model.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0b1484...6aa4e8d. Read the comment docs.

@miguelgfierro miguelgfierro merged commit a69cb1c into staging May 3, 2022
@miguelgfierro miguelgfierro deleted the simonz/correct-python-version branch May 3, 2022 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants