Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase timeout for nightly GPU integration test #1661

Merged
merged 4 commits into from
Mar 8, 2022
Merged

Conversation

anargyri
Copy link
Collaborator

@anargyri anargyri commented Mar 4, 2022

Description

Test takes more than 6 hours. Increase to 7 hours.

Related Issues

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

@anargyri
Copy link
Collaborator Author

anargyri commented Mar 4, 2022

The test failed due to Movielens site connection issues. Is there a reason why we don't use the mock Movielens data set here, or just an omission? @miguelgfierro @laserprec
If not, I will switch these to mock data.

@laserprec
Copy link
Contributor

laserprec commented Mar 4, 2022

The test failed due to Movielens site connection issues. Is there a reason why we don't use the mock Movielens data set here, or just an omission? @miguelgfierro @laserprec If not, I will switch these to mock data.

I don't think there's any problem. I must have forgotten to switch it over :p. Please go ahead!

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@anargyri anargyri merged commit 0f1f8b3 into staging Mar 8, 2022
@anargyri anargyri deleted the andreas/timeout branch March 8, 2022 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants