Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower LightGBM test AUC base value #1619

Merged
merged 4 commits into from
Jan 22, 2022
Merged

Conversation

simonzhaoms
Copy link
Collaborator

Description

The new LightGBM from SynapseML gives lower AUC value which makes smoke tests failed.
This PR lowers the test base value.

Related Issues

See #1615

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

@miguelgfierro
Copy link
Collaborator

@anargyri the change made than Ilia requires to also change the result of AUC, meaning, do we still need to merge this PR?

Copy link
Collaborator

@miguelgfierro miguelgfierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing PR blocker

Copy link
Collaborator

@miguelgfierro miguelgfierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved: waiting for the decision of Ilia and Andreas

@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2022

Codecov Report

Merging #1619 (73b6a0d) into staging (cf7bfd8) will increase coverage by 2.51%.
The diff coverage is n/a.

❗ Current head 73b6a0d differs from pull request most recent head b305bb4. Consider uploading reports for the commit b305bb4 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           staging    #1619      +/-   ##
===========================================
+ Coverage    56.68%   59.20%   +2.51%     
===========================================
  Files           88       88              
  Lines         8956     8956              
===========================================
+ Hits          5077     5302     +225     
+ Misses        3879     3654     -225     
Flag Coverage Δ
pr-gate 59.20% <ø> (+2.51%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
recommenders/evaluation/spark_evaluation.py 87.05% <0.00%> (+0.44%) ⬆️
recommenders/models/sasrec/model.py 85.19% <0.00%> (+58.91%) ⬆️
recommenders/models/sasrec/sampler.py 91.66% <0.00%> (+60.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 735df87...b305bb4. Read the comment docs.

@anargyri
Copy link
Collaborator

@anargyri the change made than Ilia requires to also change the result of AUC, meaning, do we still need to merge this PR?

Yes, I think we need to merge this PR. The other PR (early stopping parameter) does not affect AUC at all.

@simonzhaoms simonzhaoms merged commit d005c1a into staging Jan 22, 2022
@miguelgfierro miguelgfierro deleted the simonz/rectify-mmlspark-auc branch January 24, 2022 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants