Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize more flaky tests #1558

Merged
merged 2 commits into from
Oct 27, 2021
Merged

Conversation

laserprec
Copy link
Contributor

@laserprec laserprec commented Oct 27, 2021

Description

We have some flaky smoke & integration tests that are failing our nightly run every now and then. Adding flaky markers so these tests can be reran without failing the build.

Example failures: https://github.com/microsoft/recommenders/actions/runs/1384618134

Nightly build status with the current changes: nightly

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

@laserprec laserprec force-pushed the laserprec/stabilize-flaky-smoke-tests branch from e63e0d1 to a4fe15d Compare October 27, 2021 14:23
@laserprec laserprec merged commit 70259d5 into staging Oct 27, 2021
@miguelgfierro miguelgfierro deleted the laserprec/stabilize-flaky-smoke-tests branch October 28, 2021 12:52
@miguelgfierro
Copy link
Collaborator

@laserprec this is really nice, we had other super flaky tests https://github.com/microsoft/recommenders/blob/main/tests/unit/recommenders/datasets/test_wikidata.py that were skipped. Can we try this marker there and check if it works?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants