Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wutao/pmupdate #1270

Merged
merged 7 commits into from
Jan 4, 2021
Merged

Wutao/pmupdate #1270

merged 7 commits into from
Jan 4, 2021

Conversation

wutaomsft
Copy link
Collaborator

@wutaomsft wutaomsft commented Dec 29, 2020

Description

updated papermill to 2.2 and changed pm.record() to sb.glue() using scrapbook. Also updated hyperopt version to be 0.1.2 so nni does not complain anymore. pinned lightfm to 1.15 as 1.16 gives out errors in unit tests.

Related Issues

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging and not master.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@miguelgfierro
Copy link
Collaborator

Installed scrapbook in the test machines, will run again the tests to see if it works

also, I did a PR to your branch @wutaomsft, see #1271

@miguelgfierro
Copy link
Collaborator

fix #641

@miguelgfierro miguelgfierro merged commit 14fbb86 into staging Jan 4, 2021
@miguelgfierro miguelgfierro deleted the wutao/pmupdate branch January 4, 2021 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants