fix bugs in test and some conflic with FFMTextIterator #1133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danyang-liu
requested review from
anargyri,
gramhagen,
loomlike,
miguelgfierro and
yueguoguo
as code owners
|
Check out this pull request on Review Jupyter notebook visual diffs & provide feedback on notebooks. Powered by ReviewNB |
|
@miguelgfierro fix bugs |
|
@miguelgfierro I think we can merge this PR |
|
@miguelgfierro we changed data again, I am updating test, please wait a min, do not merge |
|
@miguelgfierro you can merge it, thanks! |
miguelgfierro
approved these changes
Jul 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix test about deeprec, ensure all the test about deeprec passed
some previous test failed due to the code changed, fix them.
Related Issues
#1132
Checklist:
stagingand notmaster.