Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staging to master: large refactor, LighGCN and NextItNet #1130

Merged
merged 156 commits into from
Jul 9, 2020
Merged

Conversation

miguelgfierro
Copy link
Collaborator

Description

Related Issues

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging and not master.

@loomlike
Copy link
Collaborator

loomlike commented Jul 4, 2020

Ok done for py files. General comments:

  1. It would be nice to have better unit-test coverage for the deeprec additions.
  2. Some codes could be more simpler, easier to read and maintain w/ some cleanup techniques, like using a list or dict instead of each repetitive variables, etc.

Thank you!!! 🤟

@miguelgfierro
Copy link
Collaborator Author

miguelgfierro commented Jul 6, 2020

hey @loomlike, I started to fix some of the issues. If you have time, feel free to push some of those. Tao suggested closing the PR this week. I'll continue tomorrow

@miguelgfierro miguelgfierro merged commit 839e044 into master Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.