PF-3455 add staticcheck #194
Conversation
svenwltr
force-pushed
the
add-staticcheck
branch
from
0ca9164
to
72be294
Compare
| @@ -1,5 +1,5 @@ | |||
| #!/usr/bin/env sh | |||
| set -eu | |||
| go mod vendor | |||
| test -z "$(go env GOWORK)" && go mod vendor || go work vendor | |||
There was a problem hiding this comment.
I am testing go work for simplifying major upgrades. Unfortunately go mod vendor complains and demands to use go work vendor. I tried to make it a oneliner to keep the file small and because we would to add this everywhere.
There was a problem hiding this comment.
I didn't know about go work until you mentioned it here.
I tried to make it a oneliner to keep the file small and because we would to add this everywhere.
Do we really? We'd only need this in projects that use go work and not everywhere, don't we?
There was a problem hiding this comment.
Yeah, see my test setup below. If I try to call go mod vendor on anywhere in the projects directory, Go throws an error at me.
There was a problem hiding this comment.
And to actually explain why I try to use go work: When I do a breaking change, I can immediately see the impact on those other projects without need for modifying to go.mod in each project.
So I would do a breaking change and then call my hack/buildall.sh hack, which is basically a for loop.
Also make project compatible with
go work, because I am trying to use it for better handling of our multi-repos.