Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Really love this tool, but I noticed it's quite slow when scanning for SUID / SGID files. It looks like it's repeatedly running a "find /" and scanning the entire filesystem when it checks for SUID files and then also SUID owned by root or SUID world writeable, so I made some changes so it should scan the filesystem once for all SUID / SGID files, then use that variable later when checking for files owned by root for example.
To test I removed all sections except the interesting files and ran with and without my modifications, the timings for the unmodified script were
real 5m49.574s
user 0m21.573s
sys 2m5.306s
And with my modifications:
custom
real 2m16.087s
user 0m7.370s
sys 0m50.301s
I also ran a diff over the outputs to ensure they were identical and wasn't taking shortcuts it shouldn't.
Hope this is a helpful modification!