Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version listing needs to show hidden versions if active #1608

Closed
ericholscher opened this issue Sep 24, 2024 · 1 comment · Fixed by #1609
Closed

Version listing needs to show hidden versions if active #1608

ericholscher opened this issue Sep 24, 2024 · 1 comment · Fixed by #1609
Assignees

Comments

@ericholscher
Copy link
Member

ericholscher commented Sep 24, 2024

With the Addons data we're returning, if the current version is active, we likely need to add it to the list of versions somehow.

You can see the issue here, where it's filtered out of the list:

Screenshot 2024-09-24 at 9 49 32 AM

@humitos humitos self-assigned this Sep 24, 2024
@humitos
Copy link
Member

humitos commented Sep 25, 2024

We have to add config.versions.current.hidden to this condition as well:

if (config.versions.current.type === "external") {
versions.unshift(config.versions.current);
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants