Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: test new theme version/language selector #11604

Closed
wants to merge 2 commits into from
Closed

Docs: test new theme version/language selector #11604

wants to merge 2 commits into from

Conversation

humitos
Copy link
Member

@humitos humitos commented Sep 17, 2024

@humitos humitos requested a review from a team as a code owner September 17, 2024 16:34
@ericholscher
Copy link
Member

ericholscher commented Sep 17, 2024 •
edited
Loading

Are we wanting to ship this now, or are we just testing the PR builds for now?

@humitos
Copy link
Member Author

humitos commented Sep 18, 2024

I created this PR as a way to show the work we are doing on the theme. I'd appreciate a review on the theme PR first. After that, we can merge this one and continue iterating.

@humitos humitos marked this pull request as draft September 18, 2024 10:42
@humitos
Copy link
Member Author

humitos commented Sep 19, 2024

It currently looks like this

Peek 2024-09-19 12-09

@humitos humitos closed this Sep 23, 2024
@humitos
Copy link
Member Author

humitos commented Sep 23, 2024

Superseded by #11611

@stsewd stsewd deleted the humitos/docs-theme-selectors branch September 25, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericholscher ericholscher Awaiting requested review from ericholscher ericholscher is a code owner automatically assigned from readthedocs/backend

Assignees

@humitos humitos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@humitos @ericholscher