Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add historial records for djstripe.models.Subscription #11440

Closed
wants to merge 2 commits into from

Conversation

humitos
Copy link
Member

@humitos humitos commented Jun 26, 2024

Some time ago we wanted this in
https://github.com/readthedocs/meta/issues/53#issuecomment-1234010087. It seems we wanted this to plot "historical number of subscriptions group by start_date and status".

This PR adds historial records to that model for now. If we are happy merging it, we can come back later and plot more questions related with historial data and project/organization fields.

Closes #53

Some time ago we wanted this in
readthedocs/meta#53 (comment). It seems
we wanted this to plot "historical number of subscriptions group by `start_date`
and `status`".

This PR adds historial records to that model for now. If we are happy merging
it, we can come back later and plot more questions related with historial data
and project/organization fields.

Closes #53
@humitos humitos requested a review from a team as a code owner June 26, 2024 14:21
@humitos humitos requested a review from stsewd June 26, 2024 14:21
Copy link
Member

@stsewd stsewd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should generate a migration. I think you need to put the call to register on

register(User, records_class=ExtraHistoricalRecords, app=__package__)

or in subscriptions/models.py

@humitos
Copy link
Member Author

humitos commented Jun 26, 2024

I moved the code to subscriptions/models.py. Hrm... for some reason it doesn't generate a migration 🤷🏼

@humitos
Copy link
Member Author

humitos commented Jul 11, 2024

Closing this for now. We can come back when we want to plot this data again.

@humitos humitos closed this Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants