Provides multiple language previews #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yaminyam
commented
Mar 7, 2023
Comment on lines
-37
to
+39
| repository: "readthedocs/actions" | ||
| ref: "v1" | ||
| repository: "Yaminyam/actions" | ||
| ref: "main" |
There was a problem hiding this comment.
This part has been modified for test and must be returned before merging.
humitos
reviewed
Mar 7, 2023
preview/scripts/edit-description.js
Outdated
| @@ -1,7 +1,7 @@ | |||
| module.exports = async ({inputs, github, context}) => { | |||
| const PR_NUMBER = context.issue.number; | |||
| const RTD_PROJECT_SLUG = inputs["project-slug"]; | |||
| const RTD_PROJECT_LANGUAGE = inputs["project-language"]; | |||
| const RTD_PROJECT_LANGUAGES = inputs["project-languages"].split(","); | |||
There was a problem hiding this comment.
Instead of splitting it by ,, this attribute could be a list, right? Like
project-languages:
- en
- jaThere was a problem hiding this comment.
|
@humitos Please review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I demonstrated it as follows.
lablup/backend.ai#1139
Please feel free to let me know if there is anything to improve!
close #25
📚 Documentation preview 📚: https://readthedocs-preview--26.org.readthedocs.build/en/26/