Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simultaneous support of multiple languages #25

Open
Yaminyam opened this issue Mar 6, 2023 · 4 comments · May be fixed by #26
Open

Simultaneous support of multiple languages #25

Yaminyam opened this issue Mar 6, 2023 · 4 comments · May be fixed by #26
Labels
enhancement New feature or request

Comments

@Yaminyam
Copy link

Yaminyam commented Mar 6, 2023

Can't support multiple language previews at once?
I think it would be nice to receive multiple arguments from the project language so that multiple links can be inserted.

@humitos
Copy link
Member

humitos commented Mar 6, 2023

Thanks for opening this issue. Can you please expand on the use case here and how you are particularly using this action?

@Yaminyam
Copy link
Author

Yaminyam commented Mar 6, 2023

lablup/backend.ai#1130
Our repo uses both en and kr docs at the same time.

project-language: |
    "en"
    "ko"

Currently, we are running two jobs to insert preview links each, but it would be nice to be able to insert multiple language links into one paragraph with one job, as in the example above.
Running the job twice creates two paragraphs in the current workflow.

@Yaminyam
Copy link
Author

Yaminyam commented Mar 6, 2023

And, especially when you want to insert project preview links with the same slug but different languages, if you run multiple jobs, the links from the later jobs will overwrite the existing links.
So in the above link I am using "sorna-ko" slug not "sorna".

@humitos humitos added the enhancement New feature or request label Mar 7, 2023
@humitos
Copy link
Member

humitos commented Mar 7, 2023

I understand. Thanks for expanding on this use case.

We have a similar workflow in our own project. We also run the same action twice (it's a mono-repo with multiple Read the Docs projects) and we are changing the message-template to list them in a more nice way. Take a look at this example:
Screenshot_2023-03-07_10-51-39

I think what you are suggesting is a good idea and should be implemented at some point.

@Yaminyam Yaminyam linked a pull request Mar 7, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants