-
-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 236 fetch plays datastore #311
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am posting one TODO item and a few reviews for @Angryman18 to take care of. We can get on a call in the evening if anything to discuss.
…reactplay/react-play into issue-236-fetch-plays-datastore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't completed the entire PR. Dropped some initial comments.
…y/react-play into issue-236-fetch-plays-datastore
This reverts commit 950c052.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am marking it as Approve
to unlock this PR. Please merge when all open items are resolved.
Description
This PR is created to fetch the play data from the data-store than the raw client side JSON file.
Fixes # 236
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Checklist: