Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 236 fetch plays datastore #311

Merged
merged 48 commits into from
Jun 25, 2022
Merged

Conversation

atapas
Copy link
Member

@atapas atapas commented Jun 15, 2022

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

This PR is created to fetch the play data from the data-store than the raw client side JSON file.

Fixes # 236

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@atapas atapas requested a review from Angryman18 June 15, 2022 04:56
@atapas atapas requested a review from koustov as a code owner June 15, 2022 04:56
@vercel
Copy link

vercel bot commented Jun 15, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-play ✅ Ready (Inspect) Visit Preview Jun 25, 2022 at 0:27AM (UTC)

@atapas atapas marked this pull request as draft June 15, 2022 04:57
@atapas atapas linked an issue Jun 15, 2022 that may be closed by this pull request
@atapas atapas added the work in progress The work is in progress label Jun 15, 2022
Copy link
Member Author

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am posting one TODO item and a few reviews for @Angryman18 to take care of. We can get on a call in the evening if anything to discuss.

src/common/hooks/useGetPlays.js Outdated Show resolved Hide resolved
src/index.js Outdated Show resolved Hide resolved
src/common/search/hooks/useSearchFilter.js Outdated Show resolved Hide resolved
src/common/routing/RouteDefs.jsx Outdated Show resolved Hide resolved
src/common/playlists/PlayHeaderInfo.jsx Outdated Show resolved Hide resolved
src/common/playlists/PlayMeta.jsx Outdated Show resolved Hide resolved
Copy link
Member

@koustov koustov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't completed the entire PR. Dropped some initial comments.

src/common/services/request/query/fetch-plays-filter.js Outdated Show resolved Hide resolved
src/common/hooks/useFeaturedPlays.js Show resolved Hide resolved
src/common/hooks/useGetPlays.js Show resolved Hide resolved
src/common/hooks/useGetPlays.js Outdated Show resolved Hide resolved
src/common/hooks/useGetPlays.js Outdated Show resolved Hide resolved
src/common/hooks/useGetPlays.js Outdated Show resolved Hide resolved
src/common/modal/index.jsx Show resolved Hide resolved
package.json Show resolved Hide resolved
@atapas atapas added waiting for reviewers and removed work in progress The work is in progress labels Jun 22, 2022
@atapas
Copy link
Member Author

atapas commented Jun 24, 2022

Build fails since the last push

image

This reverts commit 950c052.
package.json Show resolved Hide resolved
koustov
koustov previously approved these changes Jun 24, 2022
Copy link
Member

@koustov koustov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am marking it as Approve to unlock this PR. Please merge when all open items are resolved.

@koustov koustov self-assigned this Jun 24, 2022
@atapas atapas merged commit f4c51d9 into main Jun 25, 2022
@atapas atapas deleted the issue-236-fetch-plays-datastore branch June 25, 2022 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ [Feature request]: Fetch play list from data store
3 participants