Expose all status code constants via Response class
#432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introducing using these constants makes it easier to identify a specific HTTP status used in our code. And for our users to use readable status codes in their own code.
|
Rebased on |
WyriHaximus
approved these changes
Nov 7, 2021
This was referenced Feb 3, 2022
This was referenced Mar 22, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this changeset, we now expose all status code constants via
Responseclass. This is done by implementing the PSR-7 Message UtilStatusCodeInterfacewhich means that most common HTTP status codes are now available as class constants with theSTATUS_*prefix. For instance, the200 OKand404 Not Foundstatus codes can used asResponse::STATUS_OKandResponse::STATUS_NOT_FOUNDrespectively.Using status code constants is entirely optional and using status codes as integers remains supported of course, but we now use these constants throughout our documentation and examples to make them more readable. Accordingly, this does not affect backwards compatibility.
This builds on top of #406 (thank you @WyriHaximus!), but instead of exposing a new interface, this changeset simply ensures the existing
Responseclass implements this very interface. This makes it much easier to use these constants in application code because no separate import is required.Supersedes / closes #406