Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tag Browser and mark public Message as final to discourage inheriting from it #373

Merged
merged 2 commits into from
Jul 11, 2020
Merged

Tag Browser and mark public Message as final to discourage inheriting from it #373

merged 2 commits into from
Jul 11, 2020

Conversation

WyriHaximus
Copy link
Member

No description provided.

@WyriHaximus WyriHaximus added this to the v1.0.0 milestone Jul 10, 2020
@WyriHaximus WyriHaximus requested review from jsor, cboden and clue July 10, 2020 17:31
@WyriHaximus WyriHaximus changed the title Tag Browser as final to discourage inheriting from it Tag Browser as final and mark any other class not already final as final to discourage inheriting from it Jul 10, 2020
@WyriHaximus WyriHaximus changed the title Tag Browser as final and mark any other class not already final as final to discourage inheriting from it Tag Browser as final to discourage inheriting from it Jul 10, 2020
@WyriHaximus WyriHaximus changed the title Tag Browser as final to discourage inheriting from it Tag Browser and mark public Message as final to discourage inheriting from it Jul 10, 2020
@clue clue merged commit e13c761 into reactphp:master Jul 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsor jsor jsor approved these changes

@clue clue clue approved these changes

@cboden cboden Awaiting requested review from cboden

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@WyriHaximus @jsor @clue