Add ReactPHP core team as authors to composer.json #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsor
reviewed
Jul 6, 2020
cboden
reviewed
Jul 6, 2020
| "homepage": "https://sorgalla.com/", | ||
| "email": "jsorgalla@gmail.com" | ||
| }, | ||
| { |
There was a problem hiding this comment.
Looking at my commit history for this repo, I've primary only done peer merges and the odd tooling cleaning. I would not consider myself an author of this repo.
There was a problem hiding this comment.
@cboden Well the way I look at it, if you are on the team, reviewing code puts you at the same level of responsibility as writing code as by approving the code you say "I trust this code as if I wrote it myself and I take the responsibility for it as if I wrote it myself".
clue
approved these changes
Jul 6, 2020
jsor
approved these changes
Jul 7, 2020
cboden
approved these changes
Jul 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will show the core team as authors under the dependencies on Packagist.