Fix awaiting queued handlers when cancelling a queued handler #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a subtle bug that can be triggered by cancelling a queued middleware request handler, i.e. before it is actually started (pending). If too many handlers are already pending, cancelling one of the queued handlers should not invoke another handler. On the other hand, cancelling a pending handler should invoke the next queued handler.
This is a subtle situation that is explicitly covered by the new tests added (see last test case). The remaining test cases exist to ensure we do not introduce any regressions and this stays at 100% coverage.
I noticed this while implementing https://github.com/clue/php-mq-react and basically backported the same logic to this project 👍