Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation improvement #297

Merged
merged 1 commit into from
Jan 7, 2018
Merged

Documentation improvement #297

merged 1 commit into from
Jan 7, 2018

Conversation

seregazhuk
Copy link
Contributor

This PR removes word function from middleware definition because actually, a middleware can be both function or a callable object. So, I think it can confuse a reader.

@WyriHaximus WyriHaximus added this to the v0.8.2 milestone Jan 7, 2018
clue
clue approved these changes Jan 7, 2018
View reviewed changes
Copy link
Member

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, makes perfect sense to me! :shipit:

WyriHaximus
WyriHaximus reviewed Jan 7, 2018
View reviewed changes
Copy link
Member

@WyriHaximus WyriHaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

@WyriHaximus WyriHaximus merged commit eb9cc67 into reactphp:master Jan 7, 2018
@seregazhuk seregazhuk mentioned this pull request Mar 23, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsor jsor jsor approved these changes

@WyriHaximus WyriHaximus WyriHaximus approved these changes

@clue clue clue approved these changes

Assignees
No one assigned
Labels
easy pick help wanted maintenance
Projects
None yet
Milestone
v0.8.2
Development

Successfully merging this pull request may close these issues.
4 participants
@seregazhuk @jsor @WyriHaximus @clue